This revision was automatically updated to reflect the committed changes.
Closed by commit rG74a878348021: SourceManager: Clarify that FileInfo always
has a ContentCache, NFC (authored by dexonsmith).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D89554?vs=298
shafik accepted this revision.
shafik added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89554/new/
https://reviews.llvm.org/D89554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM if Shafik is happy
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89554/new/
https://reviews.llvm.org/D89554
___
cfe-commi
dexonsmith added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:1684
bool MyInvalid = false;
ComputeLineNumbers(Diag, Content, ContentCacheAlloc, *this, MyInvalid);
if (MyInvalid)
dexonsmith wrote:
> shafik wrote:
> > Is the `const_
dexonsmith added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:1684
bool MyInvalid = false;
ComputeLineNumbers(Diag, Content, ContentCacheAlloc, *this, MyInvalid);
if (MyInvalid)
shafik wrote:
> Is the `const_cast` just for this li
shafik added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:1684
bool MyInvalid = false;
ComputeLineNumbers(Diag, Content, ContentCacheAlloc, *this, MyInvalid);
if (MyInvalid)
Is the `const_cast` just for this line? Maybe we can loc
dexonsmith created this revision.
dexonsmith added a reviewer: arphaman.
Herald added subscribers: ributzka, martong.
Herald added a reviewer: shafik.
dexonsmith requested review of this revision.
It turns out that `FileInfo` *always* has a ContentCache. Clarify that
in the code:
- Update the pri
