[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

2020-10-16 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added a comment. In D89582#2335704 , @arsenm wrote: > In D89582#2335671 , @rampitec wrote: > >> In D89582#2335619 , @arsenm wrote: >> >>> In D89582#2335574

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

2020-10-16 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D89582#2335671 , @rampitec wrote: > In D89582#2335619 , @arsenm wrote: > >> In D89582#2335574 , @yaxunl wrote: >> >>> What if a device function is

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

2020-10-16 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added a comment. In D89582#2335619 , @arsenm wrote: > In D89582#2335574 , @yaxunl wrote: > >> What if a device function is called by kernels with different work group >> sizes, will caller's work group siz

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

2020-10-16 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D89582#2335574 , @yaxunl wrote: > What if a device function is called by kernels with different work group > sizes, will caller's work group size override callee's work group size? It's user error to call a function with a larg

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

2020-10-16 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. What if a device function is called by kernels with different work group sizes, will caller's work group size override callee's work group size? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89582/new/ https://reviews.llvm.org/D89582 ___

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

2020-10-16 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: yaxunl, rampitec. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. arsenm requested review of this revision. Herald added a subscriber: wdng. When the default flat work group size is 256, it should also ap