[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5699b8ff1b6: [clang][driver] Rename DriverOption as NoXarchOption (NFC) (authored by awarzynski). Changed prior to commit: https://reviews.llvm.o

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChain.cpp:1203 +unsigned DiagID = +Diags.getCustomDiagID(DiagnosticsEngine::Error, + "invalid

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski updated this revision to Diff 301414. awarzynski added a comment. Remove the diagnostic - Deleted the `err_drv_invalid_Xarch_argument_unsupported` diagnostic - Removed `const` from &getDiags() - otherwise I couldn't use `getCustomDiagID` (which is a non-const member function). `Diagno

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

yaxunl added a comment. In D89799#2359553 , @MaskRay wrote: > > The original purposes have mostly been eliminated. The remaining is now > -Xarch. OK. Then let's rename it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay added a comment. In D89799#2345004 , @awarzynski wrote: > Thank you all for you comments! Please find my replies below. I've picked 4 > main points raised here. > > 1 > - > > In D89799#2342677 , @rnk wrote:

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89799/new/ https://reviews.llvm.org/D89799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Thank you all for you comments! Please find my replies below. I've picked 4 main points raised here. 1 - In D89799#2342677 , @rnk wrote: > This seems like pretty corner case functionality. Do we really need this > diagnostic

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

yaxunl added a comment. I am not sure whether it is proper to rename it. Originally, this flag means driver option which is not supposed to be forwarded to tools. It is more like a reminder to driver developers since clang driver does not automatically forward options to tools and does not enfo

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay added a subscriber: yaxunl. MaskRay added a comment. @yaxunl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89799/new/ https://reviews.llvm.org/D89799 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

rnk added a comment. This seems like pretty corner case functionality. Do we really need this diagnostic? @tra @yaxun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89799/new/ https://reviews.llvm.org/D89799 ___

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay added a comment. LGTM. I think a number of options can probably drop the flag, but that can be left as a future clean-up for macOS -Xarch (can someone add a reviewer for macOS?) and CUDA -Xarch* folks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski created this revision. Herald added subscribers: cfe-commits, dexonsmith, dang. Herald added a project: clang. awarzynski requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. As discussed in [1], ClangFlags::DriverOption is currentl