This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9bc02e892f54: [SystemZ][z/OS] Set short-enums as the default
for z/OS (authored by Jonathan.Crowther, committed by abhina.sreeskantharajan).
Reposit
Jonathan.Crowther updated this revision to Diff 300050.
Jonathan.Crowther added a comment.
Forgot to set the repository for my last patch. No code changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89801/new/
https://reviews.llvm.org/D89801
Fi
abhina.sreeskantharajan accepted this revision.
abhina.sreeskantharajan added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89801/new/
https://reviews.llvm.org/D89801
___
cfe-co
Jonathan.Crowther updated this revision to Diff 299779.
Jonathan.Crowther added a comment.
Added a test for `-fno-short-enums`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89801/new/
https://reviews.llvm.org/D89801
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/zos
zibi added a comment.
LGTM, though not sure why comment is referencing -fshort-enums=0.
If '=0' is not significant perhaps delete it to remove confusion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89801/new/
https://reviews.llvm.org/D89801
SeanP added inline comments.
Comment at: clang/test/Driver/zos-driver-defaults.c:1
+// RUN: %clang -### --target=s390x-none-zos -fsyntax-only %s 2>&1 | FileCheck
%s
+// REQUIRES: clang-driver
Can you add an additional test for -fno-short-enum to make sure that w
