[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added a comment. In D90159#2466599 , @MaskRay wrote: > Should this have some tests? Even if guarded by `REQUIRES:` if some feature > is needed. Test coverage for the DDG functionality has been added under LIT and unittests. I've opened

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

MaskRay added a comment. Should this have some tests? Even if guarded by `REQUIRES:` if some feature is needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added a comment. In D90159#2454905 , @bmahjour wrote: > In D90159#2453805 , @Meinersbur > wrote: > >> Can I help fixing the Windows build problem? > > I think I have a fix (please see the updated patch),

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour updated this revision to Diff 311897. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 Files: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp llvm/include/llvm/Analysis/CFGPrinter.h

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added a comment. In D90159#2453805 , @Meinersbur wrote: > Can I help fixing the Windows build problem? I think I have a fix (please see the updated patch), but don't have access to a windows machine to verify. Would you be able to try building

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur added a comment. Can I help fixing the Windows build problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 ___ cfe-commits mailing list

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4a10732c8b: [DDG] Data Dependence Graph - DOT printer (authored by bmahjour). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur accepted this revision. Meinersbur added a comment. Thanks. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 ___ cfe-commits mailing list

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour updated this revision to Diff 311678. bmahjour added a comment. fix formatting and use interleaveComma instead of interleave. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 Files:

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Comment at: llvm/include/llvm/Analysis/DDG.h:489 + }, + [&] { OS << ", "; }); + return OS.str(); `llvm::interleaveComma`

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added inline comments. Comment at: llvm/include/llvm/Analysis/DDG.h:480 +return OS.str(); + unsigned count = 0; + for (auto : Deps) { Meinersbur wrote: > [suggestion] Instead of count, you can use `llvm::enumerate`. I think it's > nicer to check

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour updated this revision to Diff 310607. bmahjour marked 5 inline comments as done. bmahjour added a comment. Herald added subscribers: cfe-commits, dexonsmith, ecnelises, martong, javed.absar, MatzeB. Herald added a project: clang. Thanks for the review @Meinersbur and sorry for taking so