[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

2021-12-18 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. See D108752 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90232/new/ https://reviews.llvm.org/D90232 ___ cfe-commits mailing list

[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

2021-06-01 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. > A small task that will make a lot of people happy Its not the happy people that concern me, its those who end up not happy that cause us the most pain ;-) 1. I question if the rst was generated via docs/tools/dump_format_style.py or by hand, it has to be

[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

2021-06-01 Thread Nikolai Hlubek via Phabricator via cfe-commits
nhlubek added a comment. I tried to highlight the story with this bug that this commit tries to fix in the following bug report: https://bugs.llvm.org/show_bug.cgi?id=50549 It goes back to 2015 and several people have tried to come up with solutions. The solutions are not complicated but due

[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

2020-12-08 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. I agree with @MyDeveloperDay that the existing tests should not be altered. Comment at: clang/docs/ClangFormatStyleOptions.rst:1473

[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

2020-12-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I'm a little confused between BestFit and Compact I'm not a massive fan of changing unit tests, just saying. Comment at: clang/docs/ClangFormatStyleOptions.rst:1473 -**ConstructorInitializerAllOnOneLineOrOnePerLine** (``bool``) - If the