[PATCH] D90447: [AMDGPU] Add gfx1033 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89d41f3a2b82: [AMDGPU] Add gfx1033 target (authored by tpr). Changed prior to commit: https://reviews.llvm.org/D90447?vs=301953=302591#toc

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM provided the other files are updated as other reviews have mentioned. Comment at: llvm/docs/AMDGPUUsage.rst:317 +

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:317 + names. + ``gfx1033`` ``amdgcn`` dGPU - wavefrontsize64 *TBA* +

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye added inline comments. Comment at: llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test:61-64 +# RUN: yaml2obj %s -o %t -DCPU=GFX90C +# RUN: llvm-readobj -h %t | FileCheck %s --match-full-lines -DFILE=%t -DCPU=GFX90C -DFLAGS=0x32 + # RUN: yaml2obj %s -o %t

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye requested changes to this revision. t-tye added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/AMDGPUUsage.rst:317 + names. + ``gfx1033``

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr updated this revision to Diff 301953. tpr added a comment. Herald added subscribers: emaste, jholewinski. Herald added a reviewer: espindola. V3: Add missing bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr updated this revision to Diff 301931. tpr added a comment. V2: Update ELFObjectFile.cpp and elf-header-flags-mach.yaml. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447 Files:

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec added a comment. Missing changes to these files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp llvm/lib/Object/ELFObjectFile.cpp llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:317 + names. + ``gfx1033`` ``amdgcn`` dGPU - wavefrontsize64 *TBA* +

[PATCH] D90447: [AMDGPU] Add gfx1033 target

foad added a comment. Don't you need to update lib/Object/ELFObjectFile.cpp and test/Object/AMDGPU/elf-header-flags-mach.yaml? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a reviewer: jhenderson. Herald added projects: clang, LLVM. tpr requested review of this