[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

2020-11-04 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6e73cfa8363d: Basic: Change Module::Umbrella to a PointerUnion, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

2020-11-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks for cleaning it up CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90481/new/ https://reviews.llvm.org/D90481 ___ cfe-commi

[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

2020-10-30 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Change `Module::Umbrella` from a `const void *` to a `PointerUnion` of `FileEntry` and `DirectoryEntry`. We can drop the `HasUmbr