[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

2020-11-15 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw abandoned this revision. mnauw added a comment. Looks like PenaltyBreakBeforeFirstCallParameter not being considered so well has been addressed somewhat differently in D90246 , and so that does the job as well. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

2020-11-01 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4481 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; + Style.PenaltyBreakBeforeFirstCallParameter = 0; Style.AlignOperands = FormatStyle::OAS_DontAlign; MyDeveloperDay

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

2020-10-31 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. You need to supply full context diffs Comment at: clang/unittests/Format/FormatTest.cpp:4481 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; + Style.PenaltyBreakBeforeFirstCallParameter = 0; Style.AlignOperands = FormatStyle::OAS

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

2020-10-31 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. mnauw requested review of this revision. If AlignAfterOpenBracket is set to BAS_DontAlign, then it turns out that PenaltyBrea