[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98aa067109ed: [Syntax] Start to move trivial Node class definitions to TableGen. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall updated this revision to Diff 304457. sammccall added a comment. Address comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90543/new/ https://reviews.llvm.org/D90543 Files:

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall marked 3 inline comments as done. sammccall added a comment. In D90543#2373962 , @eduucaldas wrote: >> Compared to Dmitri's prototype, Nodes.td looks more like a class hierarchy >> and >> less like a grammar. (E.g. variants list the

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

eduucaldas added a comment. > Compared to Dmitri's prototype, Nodes.td looks more like a class hierarchy and > less like a grammar. (E.g. variants list the Alternatives parent rather than > vice versa). > e.g. we may introduce abstract bases like "loop" that the grammar doesn't > care about

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. > e.g. we may introduce abstract bases like "loop" that the grammar doesn't > care about in order to model is-a concepts that might make refactorings more > expressive. This is less

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall added a comment. There are *lots* more nodes that can be converted here, I'll wait to review the pattern first :-) The generated code is identical to the deleted code, except the constructor for abstract classes is protected now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall created this revision. sammccall added reviewers: gribozavr2, hokein. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. sammccall requested review of this revision. This defines two node archetypes with trivial class definitions: - Alternatives: the