michael-roe added a comment.
Thanks!
I agree with those changes; I'll implement them and then resubmit a patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90570/new/
https://reviews.llvm.org/D90570
atanasyan added a comment.
My bad, I missed that you implemented passing the option to backend.
Could you add some improvements to the patch?
1. As far as I know GCC does not accept `-mmips3d` option. It uses `-mips3d`.
We need do the same.
2. Add test cases. For the reference you might take
michael-roe added a comment.
The goal of this patch is that if you have some C code with inline MIPS
assembly language that uses MIPS3D instructions, you can get it to compile by
passing -mmips3d on the command line. (Without this command line option,
there's an awkward workaround that
atanasyan added a comment.
What's a goal of this change? Do you want to suppress an error message when the
option provided to Clang? If so, is it a real-life case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90570/new/