thakis added a comment.
This breaks tests on Windows: http://45.33.8.238/win/28408/step_9.txt
Please take a look, and revert for now if it takes a while to fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90749/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc9776c8d4ef7: [clangd] Introduce config compilation for
External blocks (authored by kadircet).
Changed prior to commit:
kadircet updated this revision to Diff 304064.
kadircet marked 7 inline comments as done.
kadircet added a comment.
- Use ExternalBlock's range for diags.
- Move diagnostic emitting to makeAbsolute.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:252
+
+ llvm::Expected makeAbsolute(std::string Path,
+
kadircet updated this revision to Diff 303956.
kadircet added a comment.
- Define an ExternalIndexSpec structure, and populate that during compile.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90749/new/
https://reviews.llvm.org/D90749
Files:
kadircet marked 5 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:256
+ diag(Error, "At least one of File or Server must be specified.",
+ llvm::SMRange());
+ return;
sammccall
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:254
+// native path.
+if (!External.File && !External.Server) {
+ diag(Error, "At least one of File or Server must be specified.",
My math friends would call
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kadircet requested review of this revision.
Herald added subscribers: ormris, MaskRay, ilya-biryukov.
Compilation logic for External
