[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

This revision was automatically updated to reflect the committed changes. Closed by commit rGcac5be495ed8: [clang-tidy] implement concurrency-mt-unsafe (authored by segoon, committed by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon added a comment. In D90944#2419420 , @lebedev.ri wrote: > Please upload all patches with full context (`-U`) Done. > I'm guessing you'll need help committing this, in which case please specify > `Author ` to be used for `git commit --author="

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307981. segoon added a comment. - git diff -U CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt clang-tools-extra/clang-tidy/concurrency/Co

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Please upload all patches with full context (`-U`) I'm guessing you'll need help committing this, in which case please specify `Author ` to be used for `git commit --author="<>"` T

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307903. segoon added a comment. - revert decls marking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt clang-tools-extra/clang-tidy/concurren

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

lebedev.ri added a comment. In D90944#2418792 , @segoon wrote: > - move static vectors out of namespace Nice. > - mark mt-unsafe decls and check for marks in exprs Eeeh. I was thinking of either some smart matcher "match any function declaration with na

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon added a comment. In D90944#2418845 , @lebedev.ri wrote: > In D90944#2418792 , @segoon wrote: > >> - mark mt-unsafe decls and check for marks in exprs > > Eeeh. > I was thinking of either some smart matcher "m

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307884. segoon added a comment. - move static vectors out of namespace - mark mt-unsafe decls and check for marks in exprs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

lebedev.ri added a comment. Looks good to me, but i'm still uneasy about doing the checking in inverted sense. Comment at: clang-tools-extra/clang-tidy/concurrency/MtUnsafeCheck.cpp:31-32 + +// Initial list was extracted from gcc documentation +static const StringRef GlibcFunc

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 306020. segoon retitled this revision from "[clang-tidy] implement concurrent-mt-unsafe" to "[clang-tidy] implement concurrency-mt-unsafe". segoon added a comment. - concurrent -> concurrency - split the patch apart CHANGES SINCE LAST ACTION https://review