[PATCH] D91037: [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts

2020-11-08 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:87 + if (!BinOpCond) +if (auto *ExprWithCleanupsCond = +dyn_cast_or_null(InnerIf->getCond())) Please fix warning. Reposit

[PATCH] D91037: [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts

2020-11-08 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Think this has an incorrect name, seems to have something to do with `bugprone-redundant-branch-condition` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037

[PATCH] D91037: [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts

2020-11-08 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. zinovy.nis requested review of this revision. Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups. Bug: https://bugs.llvm.org/show_bug.cgi?id=48008. Repository: r