This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGca2e7e59994d: [IRGen] Add !annotation metadata for auto-init
stores. (authored by fhahn).
Changed prior to commit:
fhahn added inline comments.
Comment at: clang/lib/CodeGen/CGDecl.cpp:1267
assert(!isa(constant));
- emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant);
+ emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant, true);
}
jdoerfert
thegameg accepted this revision.
thegameg added a comment.
Looks good, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91417/new/
https://reviews.llvm.org/D91417
___
cfe-commits mailing list
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGDecl.cpp:1267
assert(!isa(constant));
- emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant);
+ emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant, true);
}
Nit:
paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.
I think this looks reasonable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91417/new/
https://reviews.llvm.org/D91417
fhahn created this revision.
fhahn added reviewers: thegameg, paquette, jdoerfert, rjmccall.
Herald added subscribers: cfe-commits, dexonsmith, jfb, hiraditya.
Herald added projects: clang, LLVM.
fhahn requested review of this revision.
This patch updates Clang's IRGen to add !annotation nodes
