Re: [PATCH] D91813: [PGO] verify BFI counts after loading profile data

2020-12-14 Thread Rong Xu via cfe-commits
Thanks for catching that. I messed up the commit from another patch. Fixed in commit c36f31c. -Rong On Mon, Dec 14, 2020 at 4:50 PM dmajor via Phabricator < revi...@reviews.llvm.org> wrote: > dmajor added inline comments. > > > > Comment at: clang/lib/CodeGen/CGCall.cpp:1948 > +

[PATCH] D91813: [PGO] verify BFI counts after loading profile data

2020-12-14 Thread dmajor via Phabricator via cfe-commits
dmajor added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1948 + // xur + fprintf(stderr, "hihi 2\n"); + // FuncAttrs.addAttribute(llvm::Attribute::Hot); This looks like something for temporary local debugging, was it intentional

[PATCH] D91813: [PGO] verify BFI counts after loading profile data

2020-12-14 Thread Rong Xu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG54e03d03a7a4: [PGO] Verify BFI counts after loading profile data (authored by xur). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.o