This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG88ab38449b49: [clang][cli] Split DefaultAnyOf into a default
value and ImpliedByAnyOf (authored by jansvoboda11).
Changed prior to commit:
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
This LGTM. Thanks again for the cleanup, I think the new syntax is more
intuitive.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4027-4031
+ if
dexonsmith added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4027-4031
+ if (((FLAGS)::CC1Option) &&
\
+ (ALWAYS_EMIT ||
\
+
jansvoboda11 updated this revision to Diff 307028.
jansvoboda11 added a comment.
Add tests, fix condition in generator
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91861/new/
https://reviews.llvm.org/D91861
Files:
jansvoboda11 added a comment.
Thanks for the feedback. I left some comments inline and will update the patch
accordingly.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3762-3764
+this->KEYPATH = MERGER(this->KEYPATH, DEFAULT_VALUE);
\
+if
dexonsmith added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4038-4043
if (((FLAGS)::CC1Option) &&
\
- (ALWAYS_EMIT || EXTRACTOR(this->KEYPATH) != DEFAULT_VALUE)) {
\
+ (ALWAYS_EMIT ||
dexonsmith added a comment.
I like this direction; the logic in the `.td` files seems much cleaner. The
`MARSHALLING` macro logic seems a bit harder to follow and there may be a bug,
but I'm not sure. See comments inline.
Comment at:
jansvoboda11 created this revision.
Herald added subscribers: llvm-commits, cfe-commits, dang.
Herald added projects: clang, LLVM.
jansvoboda11 requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D91861
Files:
clang/include/clang/Driver/Options.td
