[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

2020-12-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D92006#2466114 , @DavidSpickett wrote: > The last update didn't update the expected errors. I have done so in > 9a93f95fce91fb4616cee0f307b564b253789282 >

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

2020-12-21 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. The last update didn't update the expected errors. I have done so in 9a93f95fce91fb4616cee0f307b564b253789282 and it's now passing. (I think it missed the bots since they don't build examples)

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

2020-12-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In D92006#2465239 , @psionic12 wrote: > Hi, could anyone help to commit this? I'm happy to do so, sorry about not asking earlier. I've commit on your behalf in b2ba6867eac10874bd279c73963

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

2020-12-20 Thread Yafei Liu via Phabricator via cfe-commits
psionic12 marked an inline comment as done. psionic12 added a comment. Hi, could anyone help to commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 ___ c