[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

2020-12-04 Thread Hafiz Abid Qadeer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca2888310b24: Dont use sysroot/include when sysroot is empty. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

2020-12-04 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

2020-12-04 Thread Hafiz Abid Qadeer via Phabricator via cfe-commits
abidh added a comment. @jroelofs Do you have any comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 ___ cfe-commits mailing list

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

2020-12-01 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D92176#2419011 , @manojgupta wrote: > lgtm but not an expert in this area. Ditto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

2020-11-26 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. lgtm but not an expert in this area. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176 ___ cfe-commits mailing list

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

2020-11-26 Thread Hafiz Abid Qadeer via Phabricator via cfe-commits
abidh created this revision. abidh added reviewers: jroelofs, manojgupta, cjdb. abidh added a project: clang. Herald added a subscriber: cfe-commits. abidh requested review of this revision. Baremetal toolchain add Driver.SysRoot/include to the system include paths without checking if