[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG240dd92432eb: [OpenMPIRBuilder] forward arguments as pointers to outlined function (authored by ftynse). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse added a comment. Windows failure is unrelated, broken by an earlier commit to MLIR PDL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 ___ cfe-commits mai

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308938. ftynse added a comment. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, rriddl

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308933. ftynse marked 6 inline comments as done. ftynse added a comment. Address all remaining review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 Files:

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

fghanim added a comment. Thanks; just two more mediocre things if possible. if not. you are good to go. :) @jdoerfert In D92189#2424677 , @jdoerfert wrote: > In D92189#2424216 , @fghanim wrote: > >> To be honest,

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, one comment and two nits. Feel free to commit if you agree with the suggestions or come back with concerns. Thanks for working on this and taking the time to fix it like this! =

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308698. ftynse added a comment. Simplify the code by adapting the PrivatizationCallback signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 Files: clang/lib/Cod

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

llitchev added a comment. In D92189#2425639 , @jdoerfert wrote: > While only partially related, can you leave a FIXME saying that more than 15 > arguments need to be packed in a structure? Yes, the number of varargs that is guarantee to work is 15, if mo

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse planned changes to this revision. ftynse added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:736 "Expected copy/create callback to set replacement value!"); - if (ReplacementValue == &V) -return; }

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

jdoerfert added a comment. While only partially related, can you leave a FIXME saying that more than 15 arguments need to be packed in a structure? Comment at: clang/test/OpenMP/parallel_codegen.cpp:139 // CHECK: call {{.*}}void (%struct.ident_t*, i32, void (i32*, i32*,

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse added inline comments. Comment at: clang/test/OpenMP/parallel_codegen.cpp:139 // CHECK: call {{.*}}void (%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) @__kmpc_fork_call(%struct.ident_t* [[DEF_LOC_2]], i32 2, void (i32*, i32*, ...)* bitcast (void (i32*, i32*

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308643. ftynse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang tests. The order of arguments is switched in the internal outlined function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h