[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5e6590b15b1: [ASTImporter] Support CXXDeductionGuideDecl with local typedef (authored by martong). Changed prior to commit:

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong updated this revision to Diff 310591. martong marked an inline comment as done. martong added a comment. - Remove not relevant param from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92209/new/ https://reviews.llvm.org/D92209 Files:

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong marked an inline comment as done. martong added a comment. Thanks for the review guys! Comment at: clang/lib/AST/ASTImporter.cpp:2522 + // Add to the lookupTable because we could not do that in MapImported. + Importer.AddToLookupTable(ToTypedef); +

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong updated this revision to Diff 310510. martong added a comment. - Remove `if (!DC || !LexicalDC)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92209/new/ https://reviews.llvm.org/D92209 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. There are several LLDB tests failing with this change. The TestImportBaseClassWhenClassHasDerivedMember.py is probably the only relevant one. The others are probably failing for the

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

teemperor added a comment. In D92209#2437416 , @martong wrote: > Ping. > @teemperor please take a look if you have some time. This is a really > important patch which may influence some future directions regarding the > ASTImporter. Apologies, last

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong added a comment. Ping. @teemperor please take a look if you have some time. This is a really important patch which may influence some future directions regarding the ASTImporter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92209/new/

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong marked an inline comment as done. martong added a comment. > I was thinking about to create a separate ASTImporter implementation > specifically for CTU and LLDB could have it's own implementation. For that we > just need to create an interface class with virtual functions. One

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2522 + // Add to the lookupTable because we could not do that in MapImported. + Importer.AddToLookupTable(ToTypedef); + shafik wrote: > I am not

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2522 + // Add to the lookupTable because we could not do that in MapImported. + Importer.AddToLookupTable(ToTypedef); + I am not super excited about this solution, I feel like several bugs

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong created this revision. martong added reviewers: teemperor, balazske. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. martong requested review of this revision.