steakhal added inline comments.
Comment at: clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:993
MacroLoc = LocAndUnit->first;
PPToUse = >second->getPreprocessor();
}
NoQ wrote:
> We were reverted because there's still a dependency on `ASTUnit`
NoQ added inline comments.
Comment at: clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:993
MacroLoc = LocAndUnit->first;
PPToUse = >second->getPreprocessor();
}
We were reverted because there's still a dependency on `ASTUnit` which lives in
This revision was automatically updated to reflect the committed changes.
Closed by commit rG00ffea77ad88: [analyzer][CTU] Add an abstraction layer
between libCrossTU and libAnalysis. (authored by dergachev.a).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
steakhal added inline comments.
Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124
/// Note that this class also implements caching.
-class CrossTranslationUnitContext {
+class CrossTranslationUnitContext : public CrossTUAnalysisHelper {
public:
NoQ added inline comments.
Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124
/// Note that this class also implements caching.
-class CrossTranslationUnitContext {
+class CrossTranslationUnitContext : public CrossTUAnalysisHelper {
public:
steakhal added inline comments.
Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124
/// Note that this class also implements caching.
-class CrossTranslationUnitContext {
+class CrossTranslationUnitContext : public CrossTUAnalysisHelper {
public:
martong added inline comments.
Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124
/// Note that this class also implements caching.
-class CrossTranslationUnitContext {
+class CrossTranslationUnitContext : public CrossTUAnalysisHelper {
public:
vsavchenko accepted this revision.
vsavchenko added a comment.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92432/new/
https://reviews.llvm.org/D92432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
martong accepted this revision.
martong added a comment.
Looks good, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92432/new/
https://reviews.llvm.org/D92432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92432/new/
https://reviews.llvm.org/D92432
___
cfe-commits mailing list
NoQ updated this revision to Diff 308771.
NoQ added a comment.
Whoops, fix typos in header formalities.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92432/new/
https://reviews.llvm.org/D92432
Files:
clang/include/clang/Analysis/CrossTUAnalysisHelper.h
NoQ created this revision.
NoQ added reviewers: vsavchenko, xazax.hun, baloghadamsoftware, Charusso,
martong, balazske, gamesh411.
Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy,
Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet.
NoQ requested review of this
12 matches
Mail list logo