dblaikie added a comment.
Probably worth separating these changes/fixes/tests (looks like 3 different
changes?) - at least it'd help me understand what each one of the changes does,
separately (I'm especially curious about the EmitScalarConversion one and would
like to better understand why the
probinson added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4293
+ {
+// There is no need to emit line number for unconditional branch.
+auto NL = ApplyDebugLocation::CreateEmpty(CGF);
rnk wrote:
> I see this is consistent with LAnd h
rnk added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4293
+ {
+// There is no need to emit line number for unconditional branch.
+auto NL = ApplyDebugLocation::CreateEmpty(CGF);
I see this is consistent with LAnd handling above, but
probinson created this revision.
probinson added reviewers: dblaikie, rnk.
probinson added a project: debug-info.
probinson requested review of this revision.
Herald added a project: clang.
Attaches a more appropriate debug location to the PHIs used for the
short-circuit evaluations, and makes log
