[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. Thanks! Reapplied the patch in https://github.com/llvm/llvm-project/commit/1900503595cbb84a4c6e140a9ba1a2c574c0586d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. In D92808#2602687 , @hans wrote: > In D92808#2601408 , @fhahn wrote: > >> In D92808#2600245 , @hans wrote: >> >>> Reverted in >>>

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. In D92808#2601408 , @fhahn wrote: > In D92808#2600245 , @hans wrote: > >> Reverted in >> https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 >> until this

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. In D92808#2600245 , @hans wrote: > Reverted in > https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 > until this can be fixed. Thanks! I pushed a fix for the issue in 75805dce5ff8

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. Reverted in https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 until this can be fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. The preprocessed source is attached to this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 good.s and bad.s are here: https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c28 And this shows the problematic difference between them:

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. In D92808#2600031 , @thakis wrote: >> Thank you. Let me know when you have more information. > > Repro is moving along. > https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 and onward > are getting pretty close.

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. > Thank you. Let me know when you have more information. Repro is moving along. https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 and onward are getting pretty close. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

smeenai added a comment. In D92808#2593331 , @ahatanak wrote: > In D92808#2593204 , @thakis wrote: > >> FYI, we're seeing test failures caused by this patch in iOS/arm64 builds >> when arc is used (simulator is

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. In D92808#2593204 , @thakis wrote: > FYI, we're seeing test failures caused by this patch in iOS/arm64 builds when > arc is used (simulator is fine though): > https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c11 >

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. FYI, we're seeing test failures caused by this patch in iOS/arm64 builds when arc is used (simulator is fine though): https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c11 We'll try to investigate a bit more on our side, but I wanted to give an early(ish)

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. Thanks! I didn't realize it hadn't been fixed in the patch I committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 ___ cfe-commits

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

jyknight added a comment. > I ended up reverting the changes I made to llvm/lib/IR/AutoUpgrade.cpp as the > file was including llvm/Analysis/ObjCARCUtil.h, which was violating layering. It looks like it was not actually reverted in the version ultimately submitted. I've pushed commit

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed4718eccb12: [ObjC][ARC] Use operand bundle clang.arc.attachedcall instead of (authored by ahatanak). Repository: rG LLVM Github Monorepo

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 323218. ahatanak retitled this revision from "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR" to "[ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting