[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

xbolva00 added a comment. Patch title should be adjusted I think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh updated this revision to Diff 314703. GGanesh edited the summary of this revision. GGanesh added a comment. Updaing the patch so that the simplified patch adds only few missing znver3 tests. The subsequent patches will comprehensively enable other znver3 features. Repository: rG LLVM

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh added a comment. In D92812#2439324 , @RKSimon wrote: > it looks like a very bad merge imo. Yep, Thank you! I will post smaller incremental patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

RKSimon added a comment. This patch doesn't look like it is taking into account the existing (albeit limited) support for znver3 - it looks like a very bad merge imo. It'd make much more sense to split this into several smaller incremental patches: 1 - cleanup any missing basic znver3

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper added a subscriber: bkramer. craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:548 break; - case CK_ZNVER3: -defineCPUMacros(Builder, "znver3"); Why is this being deleted? Comment at:

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper added a comment. Please upload the patch with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh created this revision. GGanesh added reviewers: RKSimon, craig.topper, lebedev.ri, courbet. GGanesh added projects: LLVM, clang. Herald added subscribers: mstojanovic, pengfei, jfb, gbedwell, hiraditya. Herald added a reviewer: andreadb. GGanesh requested review of this revision. Herald