[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e02f58780ab: [analyzer] Highlight arrows for currently selected event (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. In D92928#2913552 , @ASDenysPetrov wrote: > Or, we can find another symbiotic way. You can make changes the way without > painfull part of thinking about IE. And I will prepare the next patch > adjusting it. Thus, revisions

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. Let's load this patch and I will prepare the adjustment for IE in pursuit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. Or, we can find another symbiotic way. You can make changes the way without painfull part of thinking about IE. And I will prepare the next patch adjusting it. Thus, revisions would be smaller. That's would be easier for you to test all the things before the

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. In D92928#2890448 , @vsavchenko wrote: > IE doesn't seem to support anything. And the majority of developers (on > Linux and on MacOS) have literally no way to test it. What we gain from > supporting IE for non-existing

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. I want to say that I really appreciate the effort you put into finding all the workarounds for IE, but it makes adding new features here incredibly painful because IE doesn't seem to support anything. And the majority of developers (on Linux and on MacOS) have

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. Maybe I'm missing something, but do we really need to care about IE? The last version was released in 2013, and even Microsoft itself stops supporting IE. Why should we care? Is there anyone who uses old deprecated browser that is not maintained? `classList`

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. P.S. Sorry. My prev comments get dimmed, since I've playing with history commints, but they still are relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ https://reviews.llvm.org/D92928

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. I've made some debugging with IE. Let's keep the diagnostics IE friendly. We might not know how many users work with IE in real. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1275-1283 var scrollTo = function(el) {

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko updated this revision to Diff 348480. vsavchenko added a comment. Herald added a subscriber: manas. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ https://reviews.llvm.org/D92928 Files:

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:166 + ArrowMap(unsigned Size) : Base(Size, 0) {} + unsigned getTotalNumberOfArrows() const { return at(0); } +}; ASDenysPetrov wrote: > # Whether `size()` is not

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. Herald added a subscriber: nullptr.cpp. HTML sample looks fine! But there is the same problem as in D92639 . IE doesn't draw arrows. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:166 +

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. Here is the HTML file for the test.F14639004: report-399795.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ https://reviews.llvm.org/D92928

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a