[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

This revision was automatically updated to reflect the committed changes. Closed by commit rG74f93bc373d0: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

dmajor added a comment. I tried the updated patch against our build and it was successful. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 ___

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4020 bool IsListInit = false, bool IsInitListCopy = false) { assert(((!IsListInit && !IsInitListCopy) ||

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 314509. nullptr.cpp added a comment. Fix use-of-uninitialized-value and `-Wreturn-std-move` with delete function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added a comment. In D92936#2477764 , @dmajor wrote: > Before the revert, our bots hit the following issue where we only error out > when `-Wall` is given, so there's definitely something strange going on. https://godbolt.org/z/P1dv9f Yeah, I

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

dmajor added a comment. Before the revert, our bots hit the following issue where we only error out when `-Wall` is given, so there's definitely something strange going on. Also happens with @Quuxplusone's suggested change applied. $ cat test.cpp template < class > class RefPtr { public:

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added a comment. In D92936#2476356 , @vitalybuka wrote: > Something is not initialized > http://lab.llvm.org:8011/#/builders/74/builds/1834/steps/9/logs/stdio Confirmed; @nullptr.cpp what do you want to do about this? I hypothesize that

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

vitalybuka added a comment. Something is not initialized tihttp://lab.llvm.org:8011/#/builders/74/builds/1834/steps/9/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

aeubanks added a comment. Thanks, and checking other compilers with godbolt is a good idea (I had tried gcc locally but it was likely too old) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added a comment. In D92936#2476091 , @aeubanks wrote: > This broke [ https://godbolt.org/z/9EG7ev ] > is this intentional? Yes, intentional. This brings Clang's C++14 conformance into line with GCC/EDG/MSVC, who all already (correctly)

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

aeubanks added a comment. This broke struct A { A(); A(A&&)=delete; private: A(const A&); friend class B; }; struct B { A foo() { A a; return a; } }; with /tmp/a.cc:12:12: error: call to deleted constructor of 'A' return a;

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

This revision was automatically updated to reflect the committed changes. Closed by commit rG89b0972aa2f5: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 314208. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 313828. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. I don't fully understand the new control flow, but at least the new //behavior// (after applying this patch) looks like an improvement to me. I recommend rebasing on top-of-tree,

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp added a comment. Note: The failed test has nothing to do with this patch. Comment at: clang/lib/Sema/SemaInit.cpp:4146 CXXConstructorDecl *CtorDecl = cast(Best->Function); - if (Kind.getKind() == InitializationKind::IK_Default && -

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 311158. nullptr.cpp added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 311137. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3110 +/// +/// \returns Whether need to do the second overload resolution. If the first +/// overload resolution fails, or if the first overload resolution success but s/need/we need/

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp