This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf2661bed185e: [clang][cli] Prevent double denormalization
(authored by jansvoboda11).
Changed prior to commit:
dexonsmith accepted this revision.
dexonsmith added a comment.
LGTM too, once the test is fixed.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267
- ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager")));
+ ASSERT_EQ(count(GeneratedArgs,
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
lgtm with the test fix.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267
- ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager")));
+
jansvoboda11 added inline comments.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267
- ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager")));
+ ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1);
ASSERT_THAT(GeneratedArgs,
dexonsmith added inline comments.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267
- ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager")));
+ ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1);
ASSERT_THAT(GeneratedArgs,
jansvoboda11 updated this revision to Diff 311216.
jansvoboda11 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93094/new/
https://reviews.llvm.org/D93094
Files:
clang/include/clang/Driver/Options.td
jansvoboda11 added inline comments.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267
- ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager")));
+ ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1);
ASSERT_THAT(GeneratedArgs,
jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
Herald added a subscriber: dang.
jansvoboda11 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
If both flags created through
