[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2020-12-13 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 created this revision. nicolas17 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code example for "RecursiveASTVisitor based ASTFrontendActions" was using unique_ptr(new X) when creating the AST consumer; change it to use make

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2021-04-06 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 added a comment. I don't have commit access, please push this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93185/new/ https://reviews.llvm.org/D93185 ___ cfe-commits mailing list cfe-c

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2021-04-14 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added subscribers: MaskRay, dblaikie. dblaikie added a comment. @thakis - just FYI, Phab doesn't send mail to the mailing list when a patch is approved without any text. Please include some text when approving patches to make sure there's a record on the mailing list. (@maskray has a br

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2021-04-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D93185#2688003 , @dblaikie wrote: > @thakis - just FYI, Phab doesn't send mail to the mailing list when a patch > is approved without any text. Please include some text when approving patches > to make sure there's a record on

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2021-04-20 Thread Nico Weber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2da4ceec936e: [docs] Use make_unique in FrontendAction example (authored by nicolas17, committed by thakis). Repository: rG LLVM Github Monorepo