[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 398824. achieveartificialintelligence added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-06 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 398031. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Inspired by D116019 , use multiclass in Alias Repository: rG LLVM Github Monorepo

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-05 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397469. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Fix issue in RISCVISAInfo.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397206. achieveartificialintelligence added a comment. Use `DAGOperand` instead of `RegisterOperand` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D9329

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:217 +let Predicates = [HasStdExtF] in { +def : FPFMADynFrmAlias; +def : FPFMADynFrmAlias; craig.topper wrote: > Why do the aliases not apply to Zfinx? Becaus

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:217 +let Predicates = [HasStdExtF] in { +def : FPFMADynFrmAlias; +def : FPFMADynFrmAlias; Why do the aliases not apply to Zfinx? Repository: rG LLVM Github Monorepo CHAN

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:124 class FPFMA_rrr_frm funct2, string opcodestr, -RegisterClass rty> +RegisterOperand rty> : RVInstR4Frmhttps://reviews.llvm.org/D93298/new/ ht

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397193. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397191. achieveartificialintelligence added a comment. Address @craig.topper 's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:170 + +static DecodeStatus DecodeGPRF32RegisterClass(MCInst &Inst, uint64_t RegNo, + uint64_t Address, Can we mak

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a subscriber: khchen. craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:290 +if (ExtName == "zdinx") + Features.push_back("+zfinx"); @kito-cheng or @khchen is the right way to do this? Or should it be

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2021-12-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. I'll finish the rest of code, if this patch is acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-