[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ab803095ae5: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHA

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks for getting to the bottom of this. Agreed, and also LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93395/new/ https://re

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

dexonsmith added a comment. Please also update the commit message to explain why this is safe (that `-fp-exception-behavior` fully encapsulates the semantics for `-cc1`) rather than just saying the options were ignored (which sounds like a bug). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

dexonsmith accepted this revision. dexonsmith added a comment. LGTM. I've just done a careful audit myself, and I'm now confident this patch is correct and that there is no latent bug -- that it's correct to ignore `-f*trapping-math` on the `-cc1` command-line since `-fp-exception-mode` will al

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

SjoerdMeijer added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3080 } Opts.setFPExceptionMode(FPEB); jansvoboda11 wrote: > SjoerdMeijer wrote: > > jansvoboda11 wrote: > > > The parsing of `OPT_ftrapping_math` and `OPT_fno_trappi

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added a comment. @SjoerdMeijer If you're not comfortable reviewing this, do you know of anyone who might want to take a look? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3080 } Opts.setFPExceptionMode(FPEB); SjoerdMeijer wrote: >

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

SjoerdMeijer added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3080 } Opts.setFPExceptionMode(FPEB); jansvoboda11 wrote: > The parsing of `OPT_ftrapping_math` and `OPT_fno_trapping_math` is > immediately overwritten here. Yeah,

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

Bigcheese added a comment. This looks fine to be as that code is definitely dead. I would wait for @SjoerdMeijer in case there's a bug in the existing code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93395/new/ https://reviews.llvm.org/D93395

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added a reviewer: SjoerdMeijer. jansvoboda11 added a subscriber: SjoerdMeijer. jansvoboda11 added a comment. Tagging @SjoerdMeijer, as these flags were pulled into the `-cc1` command-line in his patch: D23840 . Repository: rG LLVM Github Monorepo

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3080 } Opts.setFPExceptionMode(FPEB); The parsing of `OPT_ftrapping_math` and `OPT_fno_trapping_math` is immediately overwritten here. Repository: rG LLVM Githu

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the `-f[no-]trapping-math` flags from