[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 322724. saiislam added a comment. Added support for optional TargetID during unbundling of archives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 Files: clang/doc

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert added a comment. In D93525#2509836 , @t-tye wrote: > In D93525#2509796 , @jdoerfert wrote: > >>> At the moment this patch defines compatibility as exact string match of >>> bundler entry ID. >>> [...] >>>

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

t-tye requested changes to this revision. t-tye added a comment. This revision now requires changes to proceed. In D93525#2509796 , @jdoerfert wrote: >> At the moment this patch defines compatibility as exact string match of >> bundler entry ID. >> [...]

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert added a comment. > At the moment this patch defines compatibility as exact string match of > bundler entry ID. > [...] > Supporting target ID requires little more work and discussion. Let's get this in first, then revisit target ID support as we need it. Repository: rG LLVM Github

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2495937 , @t-tye wrote: > In D93525#2495374 , @saiislam wrote: > >> In D93525#2493752 , @t-tye wrote: >> >>> In D93525#2493024

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

t-tye added a comment. In D93525#2495374 , @saiislam wrote: > In D93525#2493752 , @t-tye wrote: > >> In D93525#2493024 , @yaxunl wrote: >> >>> can you document this in ClangO

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2493752 , @t-tye wrote: > In D93525#2493024 , @yaxunl wrote: > >> can you document this in ClangOffloadBundler.rst ? I think we need a clear >> description about how clang-offloa

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

t-tye added a comment. In D93525#2493024 , @yaxunl wrote: > can you document this in ClangOffloadBundler.rst ? I think we need a clear > description about how clang-offload-bundler knows which file in the .a file > belongs to which target. How does the

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

yaxunl added a comment. can you document this in ClangOffloadBundler.rst ? I think we need a clear description about how clang-offload-bundler knows which file in the .a file belongs to which target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam marked 3 inline comments as done. saiislam added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:1048-1049 +while (!CurKindTriple.empty()) { + if (hasHostKind(CurKindTriple)) { +// Do nothing, we don't extract host

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 314633. saiislam added a comment. Modified to handle multiple targets/outputs in one run of the tool for archive unbundling. Other minor changes as requested in the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:142-144 + } else { +return Triple; + } No need `else` here Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:953-957

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. Refer to D80816 for earlier review of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 ___

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam created this revision. saiislam added reviewers: grokos, hfinkel, jdoerfert, JonChesterfield, ronlieb, ABataev, mdtoguchi, kbobrovs, sdmitriev, gregrodgers, kkwli0, dreachem, Tyker, jsjodin. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscri