This revision was automatically updated to reflect the committed changes.
Closed by commit rG5a85526728c9: [clang] Use enum for LangOptions::SYCLVersion
instead of unsigned (authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D935
bader accepted this revision.
bader added subscribers: mdtoguchi, erichkeane.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
@erichkeane, @mdtoguchi, we should upstream support for SYCL-2020 version in
addition to SYCL-2017.
Repository:
rG LLVM Github M
dexonsmith added a comment.
I've reviewed the code and it seems to do the right thing. I'd like a SYCL
maintainer to take a look too though.
(If for some reason changing the interface to an enum isn't desirable, maybe
there's a compromise where there's an accessor that converts back to an
inte
jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese, bader, ABataev.
Herald added subscribers: Anastasia, ebevhan, yaxunl.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`LangOptions::SYCLVe
