sammccall added a comment.
Sorry for the delay getting this landed, and thanks for the patch!
It'll be part of the clangd 12 release.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93600/new/
https://reviews.llvm.org/D93600
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f8d1e9eb27e: [clangd] When querying drivers by binary, look
in PATH too (authored by rapgenic, committed by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
rapgenic marked 3 inline comments as done.
rapgenic added a comment.
Done! My email is:
Giulio Girardi
Thank you for your help!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93600/new/
https://reviews.llvm.org/D93600
___
cfe-commits mailin
rapgenic updated this revision to Diff 313528.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93600/new/
https://reviews.llvm.org/D93600
Files:
clang-tools-extra/clangd/QueryDriverDatabase.cpp
clang-tools-extra/clangd/test/system-include-extractor.test
Index: clang-tools-extra/clang
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, this looks good, just a couple of nits.
I guess you don't have commit access, I'm happy to land this for you when
you're happy with it. Just need an email address to associate th
rapgenic marked 3 inline comments as done.
rapgenic added a comment.
I think I have fixed what you asked!
About the test, I thought it would be reasonable to test the three cases
separately, however I cannot get it to work with a single test file (I think
it's some problem with the generated fi
rapgenic updated this revision to Diff 313259.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93600/new/
https://reviews.llvm.org/D93600
Files:
clang-tools-extra/clangd/QueryDriverDatabase.cpp
clang-tools-extra/clangd/test/system-include-extractor.test
Index: clang-tools-extra/clang
sammccall added a comment.
Thanks, this looks like a good idea to me, but some quibbles with the details:
- for any string, we statically know whether it's path or WD-relative
- we should make sure all the IO gets cached
Comment at: clang-tools-extra/clangd/QueryDriverDatabase
rapgenic added a comment.
Just wanted to say that this is my first patch submission to the LLVM/clangd
project, so please call me out on any mistake!
The arc tool caught me by surprise by opening the revision before I could
double check it, hence the rename and edits...
Repository:
rG LLVM
