This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbef9eb84b2fb: [clang] NFC: Refactor custom class into a
lambda in CompilerInvocation (authored by jansvoboda11).
Repository:
rG LLVM Github Monore
jansvoboda11 added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:176
+static auto makeFlagToValueNormalizer(T Value) {
+ return makeFlagToValueNormalizer(uint64_t(Value));
}
dexonsmith wrote:
> (not a behaviour change but) I wonder if t
jansvoboda11 updated this revision to Diff 313309.
jansvoboda11 added a comment.
Extract SFINAE check into function again
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93628/new/
https://reviews.llvm.org/D93628
Files:
clang/lib/Frontend/Compiler
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
This looks like an improvement, so LGTM, but I have a couple of comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:160-161
-namespace {
-template stru
jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Change `makeFlagToValueNormalizer` so that one specialization converts all
integral/enum
