[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

wenlei added a subscriber: lxfind. wenlei added a comment. In D93747#2475852 , @dblaikie wrote: > In D93747#2470504 , @hoy wrote: > >> In D93747#2470387 , @dblaikie wrote:

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

This revision was automatically updated to reflect the committed changes. Closed by commit rG32bcfcda4e28: Rename debug linkage name with -funique-internal-linkage-names (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 315908. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 315572. hoy added a comment. Removing the UniqueDebugLinakgeNames switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2488399 , @dblaikie wrote: > In D93747#2488390 , @tmsriram wrote: > >> In D93747#2488387 , @dblaikie wrote: >> >>> Seems alright to me - I

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2488390 , @tmsriram wrote: > In D93747#2488387 , @dblaikie wrote: > >> Seems alright to me - I think we've hashed out the deeper issues (missing >> opportunity for C functions

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2488387 , @dblaikie wrote: > Seems alright to me - I think we've hashed out the deeper issues (missing > opportunity for C functions which could/should be addressed by moving the > implementation to the frontend,

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems alright to me - I think we've hashed out the deeper issues (missing opportunity for C functions which could/should be addressed by moving the implementation to the frontend, where

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482730 , @tmsriram wrote: > In D93747#2482726 , @hoy wrote: > >> In D93747#2482519 , @tmsriram wrote: >> >>> In D93747#2481494

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2482726 , @hoy wrote: > In D93747#2482519 , @tmsriram wrote: > >> In D93747#2481494 , @dblaikie wrote: >> >>> In D93747#2481383

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314955. hoy added a comment. Renaming debug linkage name if it preexisits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files:

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482519 , @tmsriram wrote: > In D93747#2481494 , @dblaikie wrote: > >> In D93747#2481383 , @hoy wrote: >> >>> In D93747#2481304

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481494 , @dblaikie wrote: > In D93747#2481383 , @hoy wrote: > >> In D93747#2481304 , @tmsriram wrote: >> >>> In D93747#2481223

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481383 , @hoy wrote: > In D93747#2481304 , @tmsriram wrote: > >> In D93747#2481223 , @tmsriram wrote: >> >>> In D93747#2481163

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481304 , @tmsriram wrote: > In D93747#2481223 , @tmsriram wrote: > >> In D93747#2481163 , @dblaikie wrote: >> >>> In D93747#2481095

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481223 , @tmsriram wrote: > In D93747#2481163 , @dblaikie wrote: > >> In D93747#2481095 , @hoy wrote: >> >>> In D93747#2481073

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481163 , @dblaikie wrote: > In D93747#2481095 , @hoy wrote: > >> In D93747#2481073 , @dblaikie wrote: >> >>> In D93747#2481053

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481095 , @hoy wrote: > In D93747#2481073 , @dblaikie wrote: > >> In D93747#2481053 , @tmsriram wrote: >> >>> In D93747#2480442

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481073 , @dblaikie wrote: > In D93747#2481053 , @tmsriram wrote: > >> In D93747#2480442 , @dblaikie wrote: >> >>> @tmsriram - any ideas what

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481053 , @tmsriram wrote: > In D93747#2480442 , @dblaikie wrote: > >> @tmsriram - any ideas what your case/example was like that might've caused >> degraded debugging

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481053 , @tmsriram wrote: > In D93747#2480442 , @dblaikie wrote: > In D93747#2470178 , @tmsriram wrote: > In

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2480442 , @dblaikie wrote: >>> In D93747#2470178 , @tmsriram >>> wrote: >>> In D93747#2469556 , @hoy wrote: >> In D93656

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. >> In D93747#2470178 , @tmsriram wrote: >> >>> In D93747#2469556 , @hoy wrote: >>> > In D93656 , @dblaikie wrote: > Though the C case is interesting

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314393. hoy added a comment. Replacing linkage names for debug declaration as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files:

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2475852 , @dblaikie wrote: > In D93747#2470504 , @hoy wrote: > >> In D93747#2470387 , @dblaikie wrote: >> >>> Please remove the clang test

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314259. hoy added a comment. Adding a switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added subscribers: AndrewLitteken, bbn, JDevlieghere, jdoerfert, aprantl. dblaikie added a comment. In D93747#2470504 , @hoy wrote: > In D93747#2470387 , @dblaikie wrote: > >> Please remove the clang test

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. This change looks good to me but I would like @rnk to sign off. My opinion is that the change is simple enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 313607. hoy added a comment. Undoing changes to the clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2470387 , @dblaikie wrote: > Please remove the clang test change - if this is an LLVM change with LLVM > test coverage, that's enough. (we don't generally test every LLVM change from > both LLVM and Clang) Sounds good. >

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. Please remove the clang test change - if this is an LLVM change with LLVM test coverage, that's enough. (we don't generally test every LLVM change from both LLVM and Clang) I'd still be curious if you could look around to see whether there are other cases of function

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2470189 , @hoy wrote: > In D93747#2470178 , @tmsriram wrote: > >> In D93747#2469556 , @hoy wrote: >> In D93656

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2470178 , @tmsriram wrote: > In D93747#2469556 , @hoy wrote: > >>> In D93656 , @dblaikie wrote: >>> Though the C case is interesting - it means you'll

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2469556 , @hoy wrote: >> In D93656 , @dblaikie wrote: >> Though the C case is interesting - it means you'll end up with C functions >> with the same DWARF 'name' but different linkage

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. > In D93656 , @dblaikie wrote: > Though the C case is interesting - it means you'll end up with C functions > with the same DWARF 'name' but different linkage name. I don't know what > that'll do to DWARF consumers - I guess they'll probably

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy created this revision. Herald added subscribers: dexonsmith, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Funtions that are renamed under -funique-internal-linkage-names have their debug