aqjune updated this revision to Diff 313945.
aqjune added a comment.
Herald added subscribers: kerbowa, nhaehnle, jvesely.
Update IRBuilder to fill poison at shufflevector's empty operand
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93793/new/
aqjune added inline comments.
Comment at: llvm/lib/IR/IRBuilder.cpp:1021
Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC));
return CreateShuffleVector(V, Undef, Zeros, Name + ".splat");
}
aqjune wrote:
> nikic wrote:
> > aqjune wrote:
aqjune added inline comments.
Comment at: llvm/lib/IR/IRBuilder.cpp:1021
Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC));
return CreateShuffleVector(V, Undef, Zeros, Name + ".splat");
}
nikic wrote:
> aqjune wrote:
> > nlopes wrote:
nikic added inline comments.
Comment at: llvm/lib/IR/IRBuilder.cpp:1012
// First insert it into an undef vector so we can shuffle it.
Type *I32Ty = getInt32Ty();
undef vector -> poison vector
Comment at: llvm/lib/IR/IRBuilder.cpp:1021
aqjune added inline comments.
Comment at: llvm/lib/IR/IRBuilder.cpp:1021
Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC));
return CreateShuffleVector(V, Undef, Zeros, Name + ".splat");
}
nlopes wrote:
> while at it, don't you want to
nlopes added inline comments.
Comment at: llvm/lib/IR/IRBuilder.cpp:1021
Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC));
return CreateShuffleVector(V, Undef, Zeros, Name + ".splat");
}
while at it, don't you want to change this one
aqjune created this revision.
aqjune added reviewers: spatel, lebedev.ri, efriedma, nlopes, regehr, RKSimon,
zhengyangl, nikic, hfinkel.
Herald added subscribers: dmgreen, kbarton, hiraditya, nemanjai.
aqjune requested review of this revision.
Herald added projects: clang, LLVM.
Herald added
