[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight updated this revision to Diff 318277. jyknight marked 8 inline comments as done. jyknight added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93922/new/ https://reviews.llvm.org/D93922 Files:

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4010 +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) { + Out << "u8__uuidof"; rsmith wrote: > Should this be `>= Ver12`

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

ldionne added a comment. In D93922#2509931 , @jyknight wrote: > Was the "group" libc++abi accept intended to be an accept for the whole > revision? Or should still ping for review from rsmith or someone else? Sorry, I should have been clearer. I just

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

rjmccall added a reviewer: fhahn. rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4032 + } } break; The old case doesn't seem to be adding the `u8__uuidof` prefix anymore. Your patch description does not say anything

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4010 +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) { + Out << "u8__uuidof"; Should this be `>= Ver12` / `> Ver11` (given

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight added a comment. Was the "group" libc++abi accept intended to be an accept for the whole revision? Or should still ping for review from rsmith or someone else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93922/new/

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

ldionne accepted this revision as: libc++abi. ldionne added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4009 +// mangling. Previously, it used a special-cased nonstandard extension. +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4009 +// mangling. Previously, it used a special-cased nonstandard extension. +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) {

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

ldionne added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4009 +// mangling. Previously, it used a special-cased nonstandard extension. +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) {

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight created this revision. jyknight added reviewers: rsmith, rjmccall. jyknight requested review of this revision. Herald added projects: clang, libc++abi, LLVM. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits. Herald added a reviewer: libc++abi. The two operations have