[PATCH] D93942: [OpenCL] Improve online documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGadb77a745692: [OpenCL] Improve online documentation. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D93942?vs=315447&id=316648#toc Repository:

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 ___ cfe-commits mailing list cfe-co

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 315447. Anastasia added a comment. Added the correction from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/User

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh added inline comments. Comment at: clang/docs/UsersManual.rst:2832 +Note that if compiled to bitcode for generic targets such as SPIR, +portable IR is produced that it can be used with various vendor +tools as well as open source tools such as `SPIRV-LLVM Translator --

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314856. Anastasia added a comment. Another fix from Marco. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/UsersManual.

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. LGTM, except for a minor typo. Otherwise my comments have been addressed. Thanks. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia added a comment. > (I only discovered the "Suggest Edit" feature halfway through the review; I > didn't update the comments I already made as I'm not sure in which format you > prefer them?) I do like the feature but I wish it would be more useful like on github that you can update

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+===+ +| Comm

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314597. Anastasia added a comment. Further change suggested by Marco CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/Us

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314594. Anastasia marked an inline comment as done. Anastasia added a comment. Addressed comments from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/do

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh added a comment. Looks good to me, just some grammar nitpicks from my side. (I only discovered the "Suggest Edit" feature halfway through the review; I didn't update the comments I already made as I'm not sure in which format you prefer them?) Comment at: clang/docs/O

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Thanks for the update. Looks good overall. A minor question about backticks. I'm no native English speaker, so I would recommend a second review from someone else too. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+===

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:2864-2868 +Adds builtin function declarations during compilations. By default +the OpenCL headers are not loaded and therefore the builtin functions + are not decla

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314184. Anastasia added a comment. Addressed comments from Marco. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/Users

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Looks good, only a few typos and minor comments. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+==

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314111. Anastasia added a comment. Fixed some build warning/formating issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clan

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov, mantognini, yaxunl. Herald added subscribers: ebevhan, jfb. Anastasia requested review of this revision. Update UsersManual and OpenCLSupport pages to reflect recent functionality i.e. SPIR-V generation, C++ for OpenCL