[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6ffe4d76fbf: [clang] Fix message text for `-Wpointer-sign` to account for plain char (authored by hubert.reinterpretcast). Changed prior to commit: https://reviews.llvm.org/D93999?vs=315648&id=315956#t

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some very minor nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7784 + " converts between pointers to integer types %select{

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast updated this revision to Diff 315648. hubert.reinterpretcast added a comment. - Address review: Mention plain char only when it appears Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93999/new/ https://reviews.llvm.org/D93999

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers to integer

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers t

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers to integer

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast added a comment. Ping, @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93999/new/ https://reviews.llvm.org/D93999 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: aaron.ballman, rsmith. Herald added subscribers: jfb, jvesely. hubert.reinterpretcast requested review of this revision. Herald added a project: clang. The `-Wpointer-sign` warning text is inappropriate for descr