fhahn requested changes to this revision.
fhahn added a comment.
This revision now requires changes to proceed.
I think this has been addressed by some commits a while ago. Marking as changes
requested to clear up review queue. Please feel free to update the patch in
case there’s anything I miss
xbolva00 added inline comments.
Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:32
//
void f1() {
for (; 1;)
Test for (; 42; )?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94366/new/
https://reviews.
xbolva00 added inline comments.
Comment at: clang/lib/CodeGen/CGStmt.cpp:797
if (llvm::ConstantInt *C = dyn_cast(BoolCondVal)) {
if (C->isOne()) {
EmitBoolCondBranch = false;
Anything non-zero?
Comment at: clang/test/CodeGen/attr
atmnpatel updated this revision to Diff 315639.
atmnpatel added a comment.
`while(1)` case was mishandled for C++11 onwards, fixed now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94366/new/
https://reviews.llvm.org/D94366
Files:
clang/lib/Cod
atmnpatel created this revision.
atmnpatel added reviewers: fhahn, jdoerfert, xbolva00.
atmnpatel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Currently, clang does not emit the `mustprogress` loop or function
attribute for loops with no
