[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added a comment. In D94367#2542809 , @atmnpatel wrote: > Wait actually, we're gonna need D94366 > anyways, I'll get address @xbolva00's comments by eod. FWIW I think we should sort this one (D94367

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. Wait actually, we're gonna need D94366 anyways, I'll get address @xbolva00's comments by eod. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. @fhahn Sorry for the hold up, I don't think I'll get to this relatively soon, I'll abandon this one and D94366 to sweep the board. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added a comment. Herald added a reviewer: jansvoboda11. @atmnpatel reverse ping. Just curious if you think you'll have time to follow up on this patch soonish? Otherwise I'm probably going to add at least the `-fno-finite-loops` option, because we have users which code breaks due to the

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

xbolva00 added a comment. Just note: gcc enables -ffinite-loops with opt level -O2 and higher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 ___ cfe-commits

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

lebedev.ri added a comment. In D94367#2489090 , @fhahn wrote: > Thanks for putting up the patch! > > I think the code here and D94366 could be > simplified if we would introduce 2 codegen options to distinguish the >

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added reviewers: rjmccall, aaron.ballman, erichkeane. fhahn added a comment. Thanks for putting up the patch! I think the code here and D94366 could be simplified if we would introduce 2 codegen options to distinguish the differences between C and C++:

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel updated this revision to Diff 315641. atmnpatel added a comment. Update CommandLineReference.rst to also include `-fno-finite-loops` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 Files:

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel created this revision. atmnpatel added reviewers: fhahn, jdoerfert, xbolva00. Herald added subscribers: dexonsmith, dang. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following D94366