[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

This revision was automatically updated to reflect the committed changes. Closed by commit rG31d375f178c2: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/ne

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2507144 , @MaskRay wrote: > In D94391#2495056 , @dblaikie wrote: > >> I'll leave this one to @aprantl > > @aprantl :) :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2495056 , @dblaikie wrote: > I'll leave this one to @aprantl @aprantl :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/new/ https://reviews.llvm.org/D94391 ___

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. I'll leave this one to @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/new/ https://reviews.llvm.org/D94391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2494531 , @dblaikie wrote: > In D94391#2494316 , @MaskRay wrote: > >> I removed `CurLoc` from call sites and tried a stage 2 build. There is such >> a difference: >> >> 0x000622

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay updated this revision to Diff 316286. MaskRay edited the summary of this revision. MaskRay added a comment. Add another workaround. stage 2 -DCMAKE_BUILD_TYPE=Debug clang is byte identical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9439

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

aprantl added a comment. I like that this makes getLineNumber behave less "magic". I'm slightly worried that this isn't quite as NFC as think (and the other cases are just not caught by the testsuite). Perhaps you could compile Clang (and a sample of Clang's ObjC(xx) tests) with the patch and d

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. In D94391#2494316 , @MaskRay wrote: > I removed `CurLoc` from call sites and tried a stage 2 build. There is such a > difference: > > 0x00062228: DW_TAG_structure_type > DW_AT_calling_convention(DW_C

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. I removed `CurLoc` from call sites and tried a stage 2 build. 0x00062228: DW_TAG_structure_type DW_AT_calling_convention(DW_CC_pass_by_value) DW_AT_name ("__va_list_tag") DW_AT_byte_size (0x18)

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2493978 , @dblaikie wrote: > In D94391#2491229 , @MaskRay wrote: > >> In D94391#2491178 , @dblaikie wrote: >> >>> Any particular bug you're

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a subscriber: JDevlieghere. dblaikie added a comment. In D94391#2491229 , @MaskRay wrote: > In D94391#2491178 , @dblaikie wrote: > >> Any particular bug you're trying to fix? (this looks like it chang

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2491178 , @dblaikie wrote: > Any particular bug you're trying to fix? (this looks like it changes the > debug locations, so it would need tests) > > Not necessarily clear that these are better debug locations? No partic

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. Any particular bug you're trying to fix? (this looks like it changes the debug locations, so it would need tests) Not necessarily clear that these are better debug locations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay created this revision. MaskRay added reviewers: debug-info, aprantl, dblaikie, rjmccall. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. getLineNumber() picks CurLoc if the parameter is invalid. This appears to mainly work a