Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: nullptr.cpp.
LGTM! As a side note, are we aware of anyone that uses short messages instead
of the full length one?
Comment at:
clang/lib/An
NoQ added a comment.
> [Warning, Note, Remark, Warning, Remark]
I excluded remarks for now with an assertion. Other tests added :)
Comment at:
clang/include/clang/Analysis/PathDiagnosticConverterDiagnosticConsumer.h:53-56
+ /// Inform the consumer that the last diagnostic ha
NoQ updated this revision to Diff 319513.
NoQ marked 22 inline comments as done.
NoQ added a comment.
Address review comments!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94476/new/
https://reviews.llvm.org/D94476
Files:
clang/include/clang/Analysis/PathDiagnosticConverterDiagnosti
NoQ added inline comments.
Comment at: clang/lib/Analysis/PathDiagnosticConverterDiagnosticConsumer.cpp:1
+//===--- PathDiagnosticConverterDiagnosticConsumer.cpp --*- C++
-*-===//
+//
steakhal wrote:
> I've seen this a few times, and I still don't know w
xazax.hun added inline comments.
Comment at:
clang/include/clang/Analysis/PathDiagnosticConverterDiagnosticConsumer.h:38
+
+ std::map>
+ PartialPDs;
A pointer pair might be small enough for a DenseMap?
Comment at: clang/lib/Analysis/Path
steakhal added a comment.
Seems pretty straightforward and clean.
The cleanup of the report's message should be reworked.
Besides, that looks good to me.
I think these cases should be tested as well:
- [Warning, Warning, Warning]
- [Warning, Note, Note]
- [Warning, Note, Note, Warning, Note]
-
vsavchenko added inline comments.
Comment at:
clang/include/clang/Analysis/PathDiagnosticConverterDiagnosticConsumer.h:23
+
+class PathDiagnosticConverterDiagnosticConsumer : public DiagnosticConsumer {
+public:
I think that this class (or file?) needs to have s
NoQ updated this revision to Diff 316025.
NoQ added a comment.
Add a few comments here and there.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94476/new/
https://reviews.llvm.org/D94476
Files:
clang/include/clang/Analysis/PathDiagnosticConverterDiagnosticConsumer.h
clang/lib/Analy
NoQ created this revision.
NoQ added reviewers: vsavchenko, xazax.hun, martong, Szelethus,
baloghadamsoftware, Charusso.
Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, mgorny.
NoQ requested review of this revision.
This `clang
