jansvoboda11 added a comment.
Committed with the parsing macro moved to the top of the file as discussed with
Michael. This will make following patches cleaner.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94682/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG39a2a233f884: [clang][cli] Parse Lang and CodeGen options
separately (authored by jansvoboda11).
Changed prior to commit:
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94682/new/
https://reviews.llvm.org/D94682
jansvoboda11 added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1831
+ MarshallingInfoString,
+!strconcat(open_cl.KeyPath, " ?
LangOptions::LaxVectorConversionKind::None"
+" :
jansvoboda11 updated this revision to Diff 316643.
jansvoboda11 added a comment.
Stop setting the default for LaxVectorConversions in CompilerInvocation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94682/new/
https://reviews.llvm.org/D94682
jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
Herald added a subscriber: dang.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
