MaskRay added a comment.
In your commit the message has just `Reviewers:`. The `Reviewers:` list does
not necessarily mean all the people on the list have acknowledged the patch so
`Reviewers:` is mostly useless. Many people agree that both `Reviewed:` &
`Differential Revision:` should be prese
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe4eaf9d82064: [OpenMP] Add support for mapping names in
mapper API (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
jhuber6 updated this revision to Diff 318061.
jhuber6 added a comment.
Adding a test case for the mapper names.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94806/new/
https://reviews.llvm.org/D94806
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
jhuber6 updated this revision to Diff 317994.
jhuber6 added a comment.
Changing the handling of `OMP_TGT_MAPTYPE_PTR_AND_OBJ` so it will not pass the
same name for the base object. This doesn't pass in the correct name, simply
makes it show up as `unknown` if queried.
Repository:
rG LLVM Git
jhuber6 updated this revision to Diff 317038.
jhuber6 added a comment.
Fixed test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94806/new/
https://reviews.llvm.org/D94806
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/test/OpenMP/declare_m
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94806/new/
https://reviews.llvm.org/D94806
___
jhuber6 created this revision.
jhuber6 added a reviewer: jdoerfert.
Herald added subscribers: guansong, yaxunl.
jhuber6 requested review of this revision.
Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1.
Herald added projects: clang, OpenMP, LLVM.
The custom mapper AP
