[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

2021-01-20 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8000c778532b: Make it possible to store a ASTNodeKind in VariantValue (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94878/new/

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

2021-01-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94878/new/ https://reviews.llvm.org/D94878

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

2021-01-19 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 317704. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94878/new/ https://reviews.llvm.org/D94878 Files: clang/include/clang/ASTMatchers/Dynamic/VariantValue.h

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

2021-01-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I assume the test coverage for this change is from existing tests that are being updated as part of another patch? Or is there test coverage missing for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

2021-01-17 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94878 Files: