[PATCH] D95204: [lld-macho] Switch default to new Darwin port

2021-02-05 Thread Jez Ng via Phabricator via cfe-commits
int3 updated this revision to Diff 321921. int3 marked an inline comment as done. int3 added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp clang/te

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

2021-02-05 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added inline comments. Comment at: llvm/utils/gn/build/BUILD.gn:240 if (host_os == "mac") { - ldflags += [ "-fuse-ld=lld.darwinnew" ] + ldflags += [ "-fuse-ld=ld64.lld" ] } else { I'm pretty sure `-fuse-ld=ld64.lld` won't work ... the

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

2021-02-02 Thread Jez Ng via Phabricator via cfe-commits
int3 updated this revision to Diff 321001. int3 added a subscriber: gkm. int3 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp clang/test/Dri

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

2021-02-02 Thread Jez Ng via Phabricator via cfe-commits
int3 updated this revision to Diff 320940. int3 retitled this revision from "[lld-macho] switch default to new Darwin port" to "[lld-macho] Switch default to new Darwin port". int3 edited the summary of this revision. int3 edited reviewers, added: thakis; removed: gkm. int3 added a comment. updat

[PATCH] D95204: [lld-macho] switch default to new Darwin port

2021-01-22 Thread Greg McGary via Phabricator via cfe-commits
gkm planned changes to this revision. gkm added a comment. Pulling this back from review ... Not ready for prime time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 ___

[PATCH] D95204: [lld-macho] switch default to new Darwin port

2021-01-21 Thread Greg McGary via Phabricator via cfe-commits
gkm created this revision. gkm added a reviewer: lld-macho. Herald added subscribers: pengfei, steven_wu, hiraditya, kristof.beyls, mgorny. gkm requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. In advance of the LLV