[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-02-02 Thread Hongtao Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hoy marked an inline comment as done. Closed by commit rGd3e2e3740d07: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the… (authored by hoy).

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-02-02 Thread Wei Mi via Phabricator via cfe-commits
wmi accepted this revision. wmi added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-02-01 Thread Hongtao Yu via Phabricator via cfe-commits
hoy marked an inline comment as done. hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe-lto.c:6 +// RUN: %clang -### %t.o -target x86_64-unknown-linux -flto -fno-pseudo-probe-for-profiling 2>&1 | FileCheck %s --check-prefix=NOPROBE +// RUN: %clang -### %t.o -

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-02-01 Thread Hongtao Yu via Phabricator via cfe-commits
hoy updated this revision to Diff 320686. hoy added a comment. Addressing Wei's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Too

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-02-01 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609-610 + // Pass an option to enable pseudo probe emission. + if (Args.hasFlag(options::OPT_fpseudo_probe_for_profiling, + options::OPT_fno_pseudo_probe_for_profiling)) +Cmd

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-02-01 Thread Wei Mi via Phabricator via cfe-commits
wmi added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609-610 + // Pass an option to enable pseudo probe emission. + if (Args.hasFlag(options::OPT_fpseudo_probe_for_profiling, + options::OPT_fno_pseudo_probe_for_profiling)) +Cmd

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-02-01 Thread Hongtao Yu via Phabricator via cfe-commits
hoy updated this revision to Diff 320680. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/CommonAr

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-01-24 Thread Wenlei He via Phabricator via cfe-commits
wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-01-24 Thread Hongtao Yu via Phabricator via cfe-commits
hoy updated this revision to Diff 318878. hoy added a comment. Addressing Wenleis' feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td clang/lib/Driver

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-01-24 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609 + // Pass an option to enable pseudo probe emission. + if (Args.hasArg(options::OPT_fpseudo_probe_for_profiling)) +CmdArgs.push_back("-plugin-opt=pseudo-probe-for-profiling");

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-01-23 Thread Wenlei He via Phabricator via cfe-commits
wenlei added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609 + // Pass an option to enable pseudo probe emission. + if (Args.hasArg(options::OPT_fpseudo_probe_for_profiling)) +CmdArgs.push_back("-plugin-opt=pseudo-probe-for-profiling"); -

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-01-22 Thread Hongtao Yu via Phabricator via cfe-commits
hoy updated this revision to Diff 318714. hoy added a comment. Fixing test failure on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td clang/lib/Driv

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

2021-01-22 Thread Hongtao Yu via Phabricator via cfe-commits
hoy created this revision. Herald added subscribers: wenlei, dang, steven_wu, hiraditya. Herald added a reviewer: jansvoboda11. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As titled. Repository: rG LLVM Github Monorepo https://