[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9286b434b76: [OpenMP] Attribute target diagnostics properly (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert updated this revision to Diff 323799. jdoerfert marked an inline comment as done. jdoerfert added a comment. Rename variable as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95912/new/ https://reviews.llvm.org/D95912 Files: c

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I agree this is an improvement on the current status and should land. Reading through it has made me nervous about our current semantic checking. In particular, I'm not sure

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert added a comment. Thanks for taking a look! Comment at: clang/lib/Sema/Sema.cpp:1798 + FunctionDecl *FD = + isa(C) ? cast(C) : dyn_cast(D); auto CheckType = [&](QualType Ty) { Fznamznon wrote: > So, we assume that lexical context is a function

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1798 + FunctionDecl *FD = + isa(C) ? cast(C) : dyn_cast(D); auto CheckType = [&](QualType Ty) { So, we assume that lexical context is a function and if it is not, we assume that the va

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert added a comment. friendly ping, also D95928 . These were supposed to be backported into 12 :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95912/new/ https://reviews.llvm.org/D95912

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert updated this revision to Diff 321012. jdoerfert added a comment. Rebase on top of D95903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95912/new/ https://reviews.llvm.org/D95912 Files: clang/include/cl

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, grokos, ABataev, Fznamznon. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Type